Skip to content

Doc Fixes #21415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2018
Merged

Doc Fixes #21415

merged 3 commits into from
Jun 12, 2018

Conversation

alimcmaster1
Copy link
Member

Closes <#21308>
Note : Defined Levels section was added in the "Notes" section opposed to "See Also".
Description of "See Also" section here, suggests it should really link to other functions etc.

@pep8speaks
Copy link

pep8speaks commented Jun 10, 2018 •
edited
Loading

Hello @alimcmaster1! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on June 11, 2018 at 22:35 Hours UTC

@alimcmaster1
Copy link
Member Author

@jschendel mind reviewing? This should make this functionality abit clearer.
Thanks,

@gfyoung gfyoung added the Docs label Jun 10, 2018
gfyoung
gfyoung approved these changes Jun 10, 2018
View reviewed changes
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cc @jreback

@gfyoung gfyoung added Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex labels Jun 10, 2018
@codecov
Copy link

codecov bot commented Jun 10, 2018 •
edited
Loading

Codecov Report

Merging #21415 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21415   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         153      153           
  Lines       49596    49596           
=======================================
  Hits        45576    45576           
  Misses       4020     4020
Flag Coverage Δ
#multiple 90.29% <ø> (ø) ⬆️
#single 41.86% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexing.py 93.55% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 415012f...11fae9b. Read the comment docs.

@alimcmaster1
Copy link
Member Author

Thanks @gfyoung, added further commit to get rid of my pep8 error causing appveyor CI to fail.

TomAugspurger
TomAugspurger reviewed Jun 11, 2018
View reviewed changes
pandas/core/indexing.py Outdated
Notes
-----
See the `Defined Levels Section
<http://pandas.pydata.org/pandas-docs/stable/advanced.html#defined-levels>`_
Copy link
Contributor

@TomAugspurger TomAugspurger Jun 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a sphinx ref, like

:ref:`advanced.shown_levels`

@jschendel
Copy link
Member

Thanks, LGTM pending @TomAugspurger's comment.

@alimcmaster1
Copy link
Member Author

Thanks both, updated as per @TomAugspurger comment. Also spotted a few other places in the codebase were we could use a Spinx ref. Will raise a separate PR.

@jreback jreback added this to the 0.23.2 milestone Jun 12, 2018
@jreback jreback merged commit e77dc7e into pandas-dev:master Jun 12, 2018
@jreback
Copy link
Contributor

jreback commented Jun 12, 2018

thanks @alimcmaster1 happy to take more PRs on other patches!

@jorisvandenbossche jorisvandenbossche modified the milestones: 0.23.2, 0.24.0 Jun 12, 2018
david-liu-brattle-1 pushed a commit to david-liu-brattle-1/pandas that referenced this pull request Jun 18, 2018
@alimcmaster1 @david-liu-brattle-1
Doc Fixes (pandas-dev#21415)
1733e2b
@alimcmaster1 alimcmaster1 deleted the alistair-docs branch June 24, 2018 22:28
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@alimcmaster1
Doc Fixes (pandas-dev#21415)
5287bc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

@jschendel jschendel jschendel approved these changes

@gfyoung gfyoung gfyoung approved these changes

Assignees
No one assigned
Labels
Docs Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
7 participants
@alimcmaster1 @pep8speaks @jschendel @jreback @TomAugspurger @gfyoung @jorisvandenbossche